-
Notifications
You must be signed in to change notification settings - Fork 19
Update embassy-executor #68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
43ba1d4
to
c8a50ed
Compare
Oh hey, we can't update embassy-executor in embedded-test, because we can't update esp-hal-embassy, because we can't update embedded-test 🙃 |
b6563e0
to
3a14d2e
Compare
Fun cross-patching to the rescue, although the embedded-test example will need an update once esp-hal is out. |
Thanks a lot. |
I'd prefer finding out what's wrong |
I've cherry-picked this onto the next branch, and released it as 0.7.0-alpha.2. also, #69 is resolved. (not adding Can you retry esp-rs/esp-hal#3889 with 0.7.0-alpha.2 ? |
abddb4e
to
5a1001d
Compare
So, this seems to be working now, which is great. ESP example needs to be pointing at the esp-hal side PR until that is merged, but that can't be merged until we can actually use embedded-test 0.7. Either way, how could we avoid this dance every time a new embassy-executor drops? (New update PR is esp-rs/esp-hal#3945 ) |
I've released embedded-test v0.7.0-alpha.3 that uses embassy-executor 0.9. And I will follow up with some ideas on how to avoid this dance in the future.. |
Thanks, I've redirected my esp-hal PR to use the released version instead of this branch. |
No description provided.